[WIP] Fix for numpy array equality checking bug #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR is a work in progress (NOT READY TO MERGE) and contains two commits.
When reviewing, please check only the second commit to avoid seeing lots of unrelated whitespace changes.
Note on line L333 I disabled the call to
int_to_Integerto isolate the bug, but this is not the final fix, because we shouldn't change the default behaviour:inttoIntegerconversion is a very important part of sympy-live UX.The underlying cause seems to be problem with
int_to_Integerin upstream, see sympy/sympy#13027