Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/incorrect manifest keys are produced #810

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Bug/incorrect manifest keys are produced #810

wants to merge 5 commits into from

Conversation

4c0n
Copy link

@4c0n 4c0n commented Jul 23, 2020

When importing a svg through an entry, the incorrect manifest key is generated.

This PR contains a failing test case to illustrate the problem.

It seems very related to #808, however I also seem to have this problem when downgrading to a lower version.

@stof
Copy link
Member

stof commented Jul 23, 2020

When downgrading, are you keeping the same versions of dependencies or downgrading as well ? Maybe the upgrade mentioned in #808 was involving more packages than Encore

@4c0n
Copy link
Author

4c0n commented Jul 23, 2020

@stof I also had to downgrade the sass-loader package, but that's it. @Lyrkan mentioned it probably came to be in version 0.29.0
#808 (comment)

@weaverryan weaverryan changed the base branch from master to main November 18, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants