Remove ESLint user-related config #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyrkan
approved these changes
Jan 13, 2020
|
Thanks @Kocal, I think that we really need this :)
Not a big issue imo, the message looks fine (edit: ahah, no wonder it looks fine and really similar to the ones we already have after pushing that missing commit 😄).
Yeah, the ones on AppVeyor have been there for a while now (and I still have no clue what causes them...), and the ones on Travis are related to TypeScript (a bit weird that they only happen for that job though). |
weaverryan
approved these changes
Mar 20, 2020
|
Thank you @Kocal! |
Kocal
added a commit
to Kocal/webpack-encore
that referenced
this pull request
Mar 20, 2020
weaverryan
added a commit
that referenced
this pull request
Apr 17, 2020
This PR was squashed before being merged into the master branch. Discussion ---------- Proposal to replace #504 (ESLint/Vue) This PR add a second argument to `Encore.enableEslintLoader()` that is used to let the ESLint loader lint `.vue` files: ```js Encore.enableEslintLoader(() => {}, { lintVue: true }); ``` Using `lintVue` won't add any ESLint configuration, that the job of the final user (see #504 (comment)). **EDIT:** While #657 is being discussed, you can use the following code to: - let ESLint process your `.vue` files - prevent the error `Use the latest vue-eslint-parser.`, see #656 ```js Encore.enableEslintLoader((options) => { delete options.parser; }, { lintVue: true }); ``` **EDIT 2:** PR #687 has been merged and issue #657 is now resolved. It means that you can use the following code to let eslint-loader handle `.vue` files: ```js Encore.enableEslintLoader(() => {}, { lintVue: true }); ``` Commits ------- 13b0750 chore: remove comment for vue files linting since #687 has been merged 2f1e85b chore: add comment for making .vue files lint working 12b3f77 eslint/vue: add 2nd parameter to Encore#enableEslintLoader eb85b24 eslint/vue: tweak config-generator aa782df eslint/vue: implement `getTest()` on ESlint loader helper bc444ff eslint/vue: tweak `WebpackConfig#enableEslintLoader()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi ✋
This PR is a proposal for #657 implementation and should fix issues encountered in #473, #574, #656, #659, and #685.
As discussed in #657, it would be better if Encore didn't configure ESLint itself. It should be done by the end user in an configuration file (e.g.:
.eslintrc.js)ESLint's
parseroption is not configured by default anymore, andbabel-eslintrequirement has been removed. We can considering this as a breaking change, end users should now configureparser: 'babel-eslintthemselves.Method
Encore.enableEslintLoader('extends-name')has been deprecated and undocumented, in order to prevent end users to configure ESLint through Encore.A nice message is also displayed when no ESLint configuration is found:
I couldn't use
FriendlyErrorsPluginfor this because error is not coming from Webpack. If someone has a better idea... 😕Pros:
delete options.parserwhen trying to useeslint-plugin-vueor@typescript-eslint/parserCons:
parseroption tobabel-eslintthemselvesWhat do you think?
Thanks.
EDIT: tests failures are unrelated I think.