Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NPM package dependencies #1258

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

abozhinov
Copy link

Hello,
I have dependency errors because using newest postcss, less, stylus loaders and for that we need to allow them in the package.json file. This PR will not break anything and it's pretty safe to merge it.

@weaverryan
Copy link
Member

Can you also run yarn install and commit the updated yarn.lock file? That may be related to the broken tests.

package.json Outdated Show resolved Hide resolved
@abozhinov
Copy link
Author

I've update the package.json and yarn.lock

@weaverryan
Copy link
Member

Tests still failing - I think we actually need to go into the 3 yarn-pnp-* directories here - https://github.com/symfony/webpack-encore/tree/main/test_apps -and run yarn install in each and commit that updated lock file. I know, annoying - but we test a lot of different situations.

@vinceAmstoutz
Copy link

@abozhinov Do y ou need any help?

@abozhinov
Copy link
Author

I run yarn install on each yarn-pnp-* directory but didn't help.

@abozhinov
Copy link
Author

I don't know why the yarn.lock files was changed... I've recreate it with the newest packages ...
➤ YN0028: The lockfile would have been modified by this install, which is explicitly forbidden.

yarn upgrade dependencies
@karpilin
Copy link

karpilin commented Feb 8, 2024

@abozhinov this is because of last weeks yarn 4.1 release. I'll make separate PR to update the test_app setups.

Meanwhile, I updated the lockfiles and I've made PR into your fork. It will pass all the tests abozhinov#1

Update lockfiles for test_apps
@karpilin
Copy link

@stof @weaverryan can you please have another look on this?

@karpilin
Copy link

@stof @weaverryan is there anything that needs correcting before this PR can be merged in?

@vinceAmstoutz
Copy link

@stof @weaverryan ?

@WebMechanic
Copy link

.bump.

@vinceAmstoutz
Copy link

vinceAmstoutz commented May 1, 2024

@fabpot @nicolas-grekas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants