Skip to content

Commit

Permalink
feature #1254 Bumping Node minimum to 20 (weaverryan)
Browse files Browse the repository at this point in the history
This PR was squashed before being merged into the main branch.

Discussion
----------

Bumping Node minimum to 20

Node 16 and 18 have reached their end of life.

Commits
-------

16c2636 Bumping Node minimum to 20
  • Loading branch information
weaverryan committed Jan 22, 2024
2 parents cc30762 + 16c2636 commit 2f54ed2
Show file tree
Hide file tree
Showing 10 changed files with 1,210 additions and 1,206 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/high-depends.yml
Expand Up @@ -14,7 +14,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-2019]
node-versions: ['16', '18', '20']
node-versions: ['20', '21']

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yaml
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Node ${{matrix.node-versions}}
uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '20'

- name: Install Yarn Dependencies
run: yarn install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/low-depends.yml
Expand Up @@ -14,7 +14,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-2019]
node-versions: ['16', '18', '20']
node-versions: ['20', '21']

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/stable-tests.yml
Expand Up @@ -14,7 +14,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-2019]
node-versions: ['16', '18', '20']
node-versions: ['20', '21']

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/testing_apps.yml
Expand Up @@ -92,7 +92,7 @@ jobs:
- name: Node ${{matrix.node-versions}}
uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'

- if: ${{ contains(matrix.app.name, 'pnpm') }}
name: Install pnpm
Expand Down
18 changes: 18 additions & 0 deletions CHANGELOG.md
@@ -1,5 +1,23 @@
# CHANGELOG

## v4.6.0

* #1254 Increased minimum Node version to 20 (@weaverryan)

* #1253 Allow sass-loader 14 (@cedric-anne)

* #1247 Allow only configuring a plugin (@gimler)

## v4.5.0

* #1235 Dropping support for Node 14 (16 is new min) and allowing `svelte` 4 (@weaverryan)

* #1185 Bump `babel-loader` from 8.2.5 to 9.1.2 (@dppanteon) - the
[CHANGELOG for babel 9](https://github.com/babel/babel-loader/releases/tag/v9.0.0)
does not list any breaking changes besides increasing the minimum Node version.

* #1224 Allow fork-ts-checker-webpack-plugin ^8.0 and ^9.0 (@buffcode)

## [v4.4.0](https://github.com/symfony/webpack-encore/releases/tag/v4.5.0)

### Features
Expand Down
4 changes: 2 additions & 2 deletions fixtures/css/autoprefixer_test.css
@@ -1,3 +1,3 @@
:fullscreen a {
display: flex
.example {
backdrop-filter: blur(10px);
}
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -23,7 +23,7 @@
"url": "https://github.com/symfony/webpack-encore/issues"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"homepage": "https://github.com/symfony/webpack-encore",
"dependencies": {
Expand Down
4 changes: 2 additions & 2 deletions test/functional.js
Expand Up @@ -1037,15 +1037,15 @@ module.exports = {
// check that the autoprefixer did its work!
webpackAssert.assertOutputFileContains(
'styles.css',
'-webkit-full-screen'
'-webkit-backdrop-filter'
);

// check that the .postcss file was also processed
// correctly (it also @import the autoprefixer_test.css
// file)
webpackAssert.assertOutputFileContains(
'postcss.css',
'-webkit-full-screen'
'-webkit-backdrop-filter'
);

done();
Expand Down
2,378 changes: 1,182 additions & 1,196 deletions yarn.lock

Large diffs are not rendered by default.

0 comments on commit 2f54ed2

Please sign in to comment.