Allow entrypoints.json to be hosted remotely #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
file_exists
onentrypoints.json
fails.strict_mode
istrue
, an exception is raised and it's imposible to load the assets.file_get_contents
is used to retrieve theentrypoints.json
contents.What I'm proposing is to use
file_get_contents
earlier to allow fetching a remoteentrypoints.json
to solve the CDN use case. Does it seem OK?On a side note, I don't see how to run the tests locally, so the feedback loop with TRavis makes it difficult to fix them. How should I do? Thanks :)