Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch type declarations (Symfony 7.0) #224

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

smnandre
Copy link
Contributor

Not 100% sure of what i'm doing there..

I try to resolve this : symfony/ux#1223

PHP Fatal error: Declaration of Symfony\WebpackEncoreBundle\CacheWarmer\EntrypointCacheWarmer::doWarmUp($cacheDir, Symfony\Component\Cache\Adapter\ArrayAdapter $arrayAdapter): bool must be compatible with Symfony\Bundle\FrameworkBundle\CacheWarmer\AbstractPhpFileCacheWarmer::doWarmUp(string $cacheDir, Symfony\Component\Cache\Adapter\ArrayAdapter $arrayAdapter, ?string $buildDir = null): bool in /home/runner/work/ux/ux/src/Turbo/vendor/symfony/webpack-encore-bundle/src/CacheWarmer/EntrypointCacheWarmer.php on line 27

And i follow that : https://symfony.com/blog/symfony-7-0-type-declarations

@weaverryan
Copy link
Member

weaverryan commented Oct 22, 2023

Thank you Simon! I was just coming to look into this - a few minor phpcs things, but I'll grab those.

@weaverryan weaverryan merged commit f3c64e2 into symfony:2.x Oct 22, 2023
6 of 7 checks passed
@smnandre
Copy link
Contributor Author

I asked some help (that i quickly and warmly got 🙇‍♂️ ) ... so thanks to them :) symfony/symfony#52234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants