bug #72 Bugfix: Properly add tags to services (Nyholm)

This PR was merged into the master branch. Discussion ---------- Bugfix: Properly add tags to services We need to make sure we can reset all resettable services. Commits ------- 3a3eac3 Properly add tags to services
symfony · Jul 1, 2019 · f0f4244 · f0f4244
2 parents 767a215 + 3a3eac3
commit f0f4244
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/DependencyInjection/WebpackEncoreExtension.php b/src/DependencyInjection/WebpackEncoreExtension.php
@@ -82,7 +82,9 @@ private function entrypointFactory(ContainerBuilder $container, string $name, st
             $name,
             $strictMode,
         ];
-        $container->setDefinition($id, new Definition(EntrypointLookup::class, $arguments));
+        $definition = new Definition(EntrypointLookup::class, $arguments);
+        $definition->addTag('kernel.reset', ['method'=>'reset']);
+        $container->setDefinition($id, $definition);
 
         return new Reference($id);
     }

diff --git a/src/Resources/config/services.xml b/src/Resources/config/services.xml
@@ -14,6 +14,7 @@
         <service id="Symfony\WebpackEncoreBundle\Asset\EntrypointLookupCollectionInterface" alias="webpack_encore.entrypoint_lookup_collection" />
 
         <service id="webpack_encore.tag_renderer" class="Symfony\WebpackEncoreBundle\Asset\TagRenderer">
+            <tag name="kernel.reset" method="reset" />
             <argument type="service" id="webpack_encore.entrypoint_lookup_collection" />
             <argument type="service" id="assets.packages" />
             <argument type="collection" />