[Validator] deprecate the use of option arrays to configure validation constraints #54744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Apr 26, 2024
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 7.1 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | yes |
| Issues | Fix #51393 |
| License | MIT |
xabbuh
force-pushed
the
issue-51393
branch
2 times, most recently
from
0c07d99
to
0d1d920
Compare
xabbuh
force-pushed
the
issue-51393
branch
5 times, most recently
from
1a3ee80
to
e58d5f9
Compare
fabpot
added a commit
that referenced
this pull request
May 1, 2024
…s with named arguments (xabbuh) This PR was merged into the 6.4 branch. Discussion ---------- [Validator] handle edge cases when constructing constraints with named arguments | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT spotted while working on #54744 Commits ------- 93eb8a0 handle edge cases when constructing constraints with named arguments
|
What a PR 👏 Quick question: don't we have deprecations expectations tests? I was not able to find tests where the new deprecations are expected. Did I miss them or is it avoided for some reason? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.