[RemoteEvent] Fix date parsing remote event payload converter

[alexandre-daubois]

Q	A
Branch?	7.1
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	-
License	MIT

AppVeyor fails on some date expectation:

There was 1 failure:
1) Symfony\Component\Mailer\Bridge\Resend\Tests\Webhook\ResendRequestParserTest::testParse with data set "C:\projects\symfony\src\Symfony\Component\Mailer\Bridge\Resend\Tests\Webhook/Fixtures\sent.json" ('{\n    "created_at": "2024-04..."\n}\n', Symfony\Component\RemoteEvent\Event\Mailer\MailerDeliveryEvent Object (...))
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
     'name' => 'received'
     'id' => '172c41ce-ba6d-4281-8a7a-541faa725748'
     'payload' => Array (...)
-    'date' => 2024-04-08T09:43:09.500000-0700
+    'date' => 2024-04-08T09:43:09.500000+0000
     'email' => 'test@example.com'
     'metadata' => Array (...)
     'tags' => Array ()
     'reason' => ''
 )
C:\projects\symfony\src\Symfony\Component\Webhook\Test\AbstractRequestParserTestCase.php:32

Indeed, this can happen depending on your configuration because the timezone is not set when creating fixtures, which leads to a difference, as shown here: https://3v4l.org/iFBMq.

Defining the timezone in the parsing should solve this flaky test.

[xabbuh]

Are we still missing some fixtures? I still see failures in the related AppVeyor job. :)

[alexandre-daubois]

That's really weird, I'm investigating. 🕵️

[alexandre-daubois]

Got it. Fixing this bug actually highlighted another one in the remote event payload conversion. That's fixed as well 🙂

[fabpot]

Thank you @alexandre-daubois.