Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeInfo] Ease getting base type on nullable types #54670

Merged
merged 1 commit into from May 2, 2024
Merged

[TypeInfo] Ease getting base type on nullable types #54670

merged 1 commit into from May 2, 2024

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Apr 19, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

Allow retrieving base type on "nullable union types" (ie: string|null) without getting a LogicException.

@carsonbot carsonbot added this to the 7.1 milestone Apr 19, 2024
Korbeil
Korbeil approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@Korbeil Korbeil left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xabbuh xabbuh added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Apr 30, 2024
@fabpot
Copy link
Member

fabpot commented May 2, 2024

Thank you @mtarld.

@fabpot fabpot merged commit e02306b into symfony:7.1 May 2, 2024
8 of 10 checks passed
@fabpot fabpot mentioned this pull request May 2, 2024
Open
@mtarld mtarld deleted the fix/improve-get-base-type branch May 2, 2024 08:41
@fabpot fabpot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@Korbeil Korbeil Korbeil approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Reviewed TypeInfo
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mtarld @fabpot @Korbeil @xabbuh @carsonbot