[Console] Better error handling when misuse of ArgvInput with arrays
#54576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Apr 12, 2024
|
I would consider it a bug if it throws fatal errors on wrong usage 🤔 |
@OskarStark the usage is a misuse though |
|
I understand, but would also vote for a bugfix, even if its most likely gonna be merged as a new feature 👍 |
OskarStark
changed the title
ArgvInput with arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When we don't use
ArgvInputcorreclty, and use array in $argv values, it returns different PHP fatal errors.See all details and how to reproduce it in the issue #53836
Solution
In this PR
Note : Old PR #54147 was targeting 5.4, see this comment for more details