-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DX: re-apply CS #53233
DX: re-apply CS #53233
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,7 @@ | |
{ | ||
private function createUser(array $claims): OidcUser | ||
{ | ||
if (!\function_exists(\Symfony\Component\String\u::class)) { | ||
if (!\function_exists(u::class)) { | ||
Check failure on line 27 in src/Symfony/Component/Security/Http/AccessToken/Oidc/OidcTrait.php GitHub Actions / PsalmUndefinedClass
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we need the namespace to check for the existence of the function (fixed in 862c6fb) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good catch, let me convert it into bug report: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I find this very curious inconsistency on PHP engine side. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. deserves a bug report to php-src IMHO There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see reason why PHP allows for that. For |
||
throw new \LogicException('You cannot use the "OidcUserInfoTokenHandler" since the String component is not installed. Try running "composer require symfony/string".'); | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -479,7 +479,7 @@ public function testCollapse() | |
], | ||
[ | ||
'bar' => 123, | ||
] | ||
], | ||
]); | ||
|
||
$dumper = new CliDumper(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also be imported, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this PR, I applied the fully_qualified_strict_types rule, which (with current config) simplifies usage of symbols.
If you want to import symbols, we can enable
import_symbols
.Please decide if you would like to go this path as separated PR: #53244