[Process] Fixed a problem on RHEL5 where the exit code was incorrect #4970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RHEL5 will intermittently result in an exit code of -1 [1] due to proc_get_status() being called after the process has completed but outside of updateStatus() which saves the exit code. [1]: composer/composer#876
fabpot
added a commit
that referenced
this pull request
Jul 19, 2012
Commits ------- 310c458 [Process] Fixed a problem on RHEL5 where the exit code was incorrect Discussion ---------- [Process] Fixed a problem on RHEL5 where the exit code was incorrect Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes License of the code: MIT RHEL5 will intermittently result in an exit code of -1 due to `proc_get_status()` being called after the process has completed but outside of `updateStatus()` which saves the exit code. See composer/composer#876
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
License of the code: MIT
RHEL5 will intermittently result in an exit code of -1 due to
proc_get_status()being called after the process has completed but outside ofupdateStatus()which saves the exit code.See composer/composer#876