Speed up Psalm tests #49001
Merged
Speed up Psalm tests #49001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might not be able to actually see this working until #49000 is merged... |
|
@danepowell #49000 has been merged, you may want to rebase. :) |
|
This sped up Psalm tests from 40 minutes to 3 minutes! 😂 |
danepowell
force-pushed
the
psalm-speedup
branch
from
d28c6c6
to
3a89d8d
Compare
stof
requested changes
Jan 24, 2023
stof
reviewed
Jan 24, 2023
7 tasks
danepowell
requested review from
stof and
javiereguiluz
and removed request for
stof
stof
approved these changes
Jan 24, 2023
xabbuh
approved these changes
Jan 26, 2023
|
We should merge this on 5.4, isn't it? |
nicolas-grekas
requested review from
yceruto,
wouterj,
chalasr,
dunglas and
OskarStark
as code owners
nicolas-grekas
force-pushed
the
psalm-speedup
branch
from
cc8e6cf
to
89be707
Compare
|
Thank you @danepowell. |
| with: | ||
| php-version: ${{ env.php-version }} | ||
| extensions: ${{ env.extensions }} | ||
| key: cache-v1 # can be any string, change to clear the extension cache. |
There was a problem hiding this comment.
on 6.3 the list of extensions is not the same as on 6.2/5.4
shouldn't we vary this by php-version + extensions?
There was a problem hiding this comment.
I haven't used GitHub Actions caching much, but I think it will attempt to restore the cache from the current branch before falling back to the default branch. So there shouldn't be any harm in reusing a cache key across branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setupphp maintainer recommends caching the couchbase extension using the cache-extensions action. This should speed up Psalm runs from 14 minutes to 2 minutes!