[Intl] Update the ICU data to 72.1 - 5.4 #47918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jderusse
commented
Oct 19, 2022
•
jderusse
commented
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | / |
| License | MIT |
| Doc PR | / |
This comment was marked as outdated.
This comment was marked as outdated.
|
In previous versions, we also patched the oldest maintained branch (aka 4.4). See https://github.com/symfony/symfony/pulls?q=is%3Apr+icu+author%3Ajderusse+is%3Aclosed But this branch still use the Given 4.4 is soon EOL, should I open a second PR for ICU 72.1? |
|
I'm okay with not updating 4.4. |
fabpot
approved these changes
Oct 20, 2022
|
Thank you @jderusse. |
This was referenced Oct 28, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.