Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] Set COMPOSER_NO_AUDIT #47353

Closed
wants to merge 1 commit into from
Closed

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Aug 21, 2022

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Running the audit step introduced in https://github.com/composer/composer/releases/tag/2.4.0 should not be necessary in a CI context.
The env var could be set by https://github.com/shivammathur/setup-php directly at some point, but it's not for sure yet: shivammathur/setup-php#635.

@carsonbot carsonbot added this to the 4.4 milestone Aug 21, 2022
@xabbuh
Copy link
Member

xabbuh commented Aug 22, 2022

The difference can be spotted if you compare https://github.com/symfony/symfony/runs/7939537131?check_suite_focus=true#step:8:214 (this PR) with https://github.com/symfony/symfony/runs/7939180947?check_suite_focus=true#step:10:301.

@danidoedel
Copy link

They already merged it so this might not be necessary anymore? I might be wrong though.
shivammathur/setup-php#636

@chalasr
Copy link
Member Author

chalasr commented Aug 22, 2022

Seems like you're right yes, thanks @danidoedel. Closing here for now

@xabbuh xabbuh closed this Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants