[HttpFoundation] [PDO] Don't fetch time when reading the session #43120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
stof
approved these changes
Sep 21, 2021
Currently, the SQL does not guarantee fixed names for the fetched columns in |
|
Looks like this breaks some tests. Maybe they were relying on the BC layer by storing the lifetime instead of the expiry ? |
|
Thanks for explanation, @stof. |
IonBazan
force-pushed
the
pdo-session-cleanup
branch
from
c9e1801
to
6111389
Compare
fabpot
approved these changes
Sep 21, 2021
fabpot
force-pushed
the
pdo-session-cleanup
branch
from
6111389
to
fb9508f
Compare
|
Thank you @IonBazan. |
fabpot
added a commit
that referenced
this pull request
Oct 12, 2021
…obion) This PR was merged into the 6.0 branch. Discussion ---------- [HttpFoundation] remove legacy session lifetime logic | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> This part was only relevant for keeping bc with the old lifetime data. Has been forgotten to be removed in #41334 and #43120 Commits ------- 54a578b [HttpFoundation] remove legacy session lifetime logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #33169 (comment)
BTW is there a reason we are using
FETCH_NUMinstead ofFETCH_ASSOCfor more readability?