[Mime] update types map #41016
[Mime] update types map #41016
Conversation
nicolas-grekas
commented
May 1, 2021
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 5.x |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
| @@ -1192,15 +1224,15 @@ public function guessMimeType(string $path): ?string | |||
| 'audio/mp4' => ['m4a', 'mp4a', 'f4a'], | |||
| 'audio/mpeg' => ['mp3', 'mpga', 'mp2', 'mp2a', 'm2a', 'm3a'], | |||
| 'audio/mpegurl' => ['m3u', 'm3u8', 'vlc'], | |||
| 'audio/ogg' => ['oga', 'ogg', 'spx', 'opus'], | |||
| 'audio/ogg' => ['ogg', 'oga', 'spx', 'opus'], | |||
There was a problem hiding this comment.
we should probably keep the existing order
There was a problem hiding this comment.
ogg is really the preferred file extension, see eg https://fr.wikipedia.org/wiki/Ogg
we already changed the order eg in symfony/mime@aa1d922
This one is now autogenerated, so it will stay stable.
| @@ -1297,10 +1329,13 @@ public function guessMimeType(string $path): ?string | |||
| 'font/collection' => ['ttc'], | |||
| 'font/otf' => ['otf'], | |||
| 'font/ttf' => ['ttf'], | |||
| 'font/woff' => ['woff', 'woff2'], | |||
There was a problem hiding this comment.
I'm not sure we should remove existing extensions
There was a problem hiding this comment.
it's not been removed: it's been split in two distinct mime types, one for each version.
There was a problem hiding this comment.
I had a second look and I think we should keep the work from the upstream source. They made the split and there should be a reason for it.
nicolas-grekas
force-pushed
the
mime
branch
5 times, most recently
from
4742739
to
e7ab315
Compare
|
FYI: this introduced a small regression for our test suite but I've sent in a PR to work around it: laravel/framework#37332 @nicolas-grekas This is a similar change to #39225 which broke a few things when Symfony 5.2 was released. Just want to make you aware of that. |
|
Thanks for the ping. I think the change makes sense here, .mov is more common than .qt, so updating on laravel's side looks appropriate to me. |
