Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serializer] Fix tests wrongly marked as incomplete #39975

Merged
merged 1 commit into from Jan 26, 2021
Merged

[Serializer] Fix tests wrongly marked as incomplete #39975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Symfony/Component/Serializer/Tests/Normalizer/Features/IgnoredAttributesTestTrait.php
View file
Open in desktop
Expand Up @@ -38,8 +38,6 @@ public function testIgnoredAttributesNormalize()
$normalizer->normalize($objectOuter, null, $context)
);

$this->markTestIncomplete('AbstractObjectNormalizer::getAttributes caches attributes by class instead of by class+context, reusing the normalizer with different config therefore fails. This is being fixed in https://github.com/symfony/symfony/pull/30907');

$context = ['ignored_attributes' => ['foo', 'inner']];
$this->assertEquals(
[
Expand Down