Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serializer] fix decoding float XML attributes starting with 0 #38669

Merged
merged 1 commit into from Oct 23, 2020
Merged

[Serializer] fix decoding float XML attributes starting with 0 #38669

merged 1 commit into from Oct 23, 2020

Conversation

marcin-kruk
Copy link

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #38666
License MIT
Doc PR n/a

This is a naive approach to fix #38666, assuming it is something worth fixing.

I checked different cases and it seems to be fixing all of them, but I bet there will be some other edge cases which still won't be covered properly.

@marcin-kruk marcin-kruk mentioned this pull request Oct 21, 2020
Closed
Nyholm
Nyholm reviewed Oct 21, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. I see you added tests and everything. Well done!

I have some questions that I would like your help answering.

src/Symfony/Component/Serializer/Tests/Encoder/XmlEncoderTest.php Show resolved Hide resolved
src/Symfony/Component/Serializer/Encoder/XmlEncoder.php Outdated Show resolved Hide resolved
@marcin-kruk
Copy link
Author

It seems that fabbot is asking me to fix something I didn't change - an exception message formatting in a different method.
I updated my branch with upstream and it's up to date, so it's not the reason.
Any ideas why it failed and how to sort it out?

@chalasr chalasr added this to the 3.4 milestone Oct 22, 2020
@nicolas-grekas nicolas-grekas changed the title [Serializer] fixed decoding float XML attributes started with 0 [Serializer] fixed decoding float XML attributes starting with 0 Oct 22, 2020
@nicolas-grekas nicolas-grekas changed the title [Serializer] fixed decoding float XML attributes starting with 0 [Serializer] fix decoding float XML attributes starting with 0 Oct 22, 2020
nicolas-grekas
nicolas-grekas approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(with one minor comment)

Nyholm
Nyholm approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy to merge after @jderusse is happy

@Nyholm Nyholm requested a review from jderusse October 22, 2020 20:54
jderusse
jderusse approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

dunglas
dunglas approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@fabpot
Copy link
Member

fabpot commented Oct 23, 2020

Thank you @marcin-kruk.

@fabpot fabpot merged commit 85e8de6 into symfony:3.4 Oct 23, 2020
This was referenced Oct 28, 2020
Merged
Merged
This was referenced Oct 28, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas dunglas approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@jderusse jderusse jderusse approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
Bug Serializer Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@marcin-kruk @fabpot @dunglas @nicolas-grekas @jderusse @Nyholm @chalasr @carsonbot