Don't call createMock with an array of interfaces #38079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
bugfix/create-mock-with-array
branch
from
556aba1
to
a8e762d
Compare
fabpot
approved these changes
Sep 7, 2020
|
Thank you @derrabus. |
chalasr
added a commit
that referenced
this pull request
Sep 7, 2020
…erfaces (derrabus) This PR was merged into the 5.1 branch. Discussion ---------- [SecurityHttp] Don't call createMock() with multiple interfaces | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #37564 | License | MIT | Doc PR | N/A Continuation of #38079 for the 5.1 branch. Commits ------- 028ec0c [SecurityHttp] Don't call createMock() with multiple interfaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit 8 allows us to pass an array of interfaces to
createMock(). The result was a mock object that implemented all of the given interfaces. This feature has sadly been removed (see sebastianbergmann/phpunit#3955), which forces us to create dummy classes that can be mocked instead. I've done this already on the 3.4 branch with #37566.This PR fixes all affected tests (that I could find) on the 4.4 branch.