[Serializer] Fix configuration of the cache key #36340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
changed the title
dunglas
changed the title
dunglas
force-pushed
the
fix-exclude-cache-key
branch
from
981b57a
to
2875404
Compare
|
It's only an issue if the default context for the cache key is changed by a child class and if the constructor is called afterwards, doesn't it? |
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
|
A test case would be nice if you can. |
|
@alanpoulain it's even the case if you just pass the keys to exclude as parameter of the constructor. |
dunglas
force-pushed
the
fix-exclude-cache-key
branch
from
e7e2aa3
to
116110a
Compare
|
Is this one still relevant? I see that the original issue has been closed as the problem has been fixed in PHP itself IIUC? /cc @dunglas @nicolas-grekas |
|
AFAIK it's still an issue. |
|
@dunglas Ok, can you rebase so that we can merge? |
fabpot
force-pushed
the
fix-exclude-cache-key
branch
from
116110a
to
3b034cb
Compare
|
Thank you @dunglas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a bug prevents to configure the context keys to exclude from the cache key computation. The value is always replaced in the constructor. This PR fixes the problem.