[Security] Rework firewall access denied rule #34476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nesk
changed the title
nesk
force-pushed
the
security-access-denied-rework
branch
from
baa448e
to
c573f66
Compare
|
Rebased the commit to define @dimabory as the author of the commit. |
nesk
force-pushed
the
security-access-denied-rework
branch
from
c573f66
to
9954f18
Compare
|
Thank you for this PR. I've been researching this for about 45 minutes now. This is the wrong approach Im afraid. The AccesDeniedHandler should only be called when an authenticated users is trying to access a resource they are not allowed to access. If an anonymous user is trying to access a protected resource, then a I made symfony/symfony-docs#13615 to avoid confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently impossible to provide a AccessDeniedHandler to Symfony, it will just be ignored. See #28229 for details.
@dimabory submitted a PR (#30423) to fix this, which was merged, but then reverted (#31142) due to a BC break in 3.4 branch (#31136).
Since the bug reported in #28229 still exists, I was planning to do a PR in the master branch before the 5.0 release, however time passed and I didn't see it would be released that soon. I hope this could still be merged as a hotfix in the 5.0 branch (despite the BC break) since I find this bug really annoying.