[Yaml] Added yaml-lint binary #34387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jschaedl
commented
Nov 15, 2019
•
jschaedl
commented
| Q | A |
|---|---|
| Branch? | 5.1 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | Fix #18987 |
| License | MIT |
| Doc PR | tbd. |
xabbuh
requested changes
Nov 15, 2019
jschaedl
force-pushed
the
issue-18987
branch
from
0636b4c
to
20e1117
Compare
derrabus
approved these changes
Nov 17, 2019
stof
requested changes
Nov 23, 2019
jschaedl
force-pushed
the
issue-18987
branch
2 times, most recently
from
252dcff
to
38cec58
Compare
jschaedl
force-pushed
the
issue-18987
branch
from
38cec58
to
2640dfe
Compare
|
Hi @xabbuh, ready to be merged, I guess? :-) |
|
Looks like the failing tests are not related. So this PR is ready to be merged imho. |
xabbuh
approved these changes
Jan 11, 2020
fabpot
approved these changes
Jan 11, 2020
|
Thank you @jschaedl. |
fabpot
added a commit
that referenced
this pull request
Jan 11, 2020
This PR was merged into the 5.1-dev branch. Discussion ---------- [Yaml] Added yaml-lint binary | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | no | New feature? | yes | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #18987 <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | tbd. <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Commits ------- 2640dfe [Yaml] Introduce yaml-lint binary
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.