Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HttpCache] fixed if-modified-since header default to an empty string if the last-modified header was not set #34016

Closed
wants to merge 1 commit into from
Closed

[HttpCache] fixed if-modified-since header default to an empty string if the last-modified header was not set #34016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php
View file
Open in desktop
Expand Up @@ -352,7 +352,7 @@ protected function validate(Request $request, Response $entry, $catch = false)
}

// add our cached last-modified validator
$subRequest->headers->set('if_modified_since', $entry->headers->get('Last-Modified'));
$subRequest->headers->set('if_modified_since', $entry->headers->get('Last-Modified', ''));

// Add our cached etag validator to the environment.
// We keep the etags from the client to handle the case when the client
Expand Down