Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to set SameSite config to 'none' #33927

Merged
merged 1 commit into from Oct 9, 2019
Merged

Allow to set SameSite config to 'none' #33927

merged 1 commit into from Oct 9, 2019

Conversation

ihmels
Copy link
Contributor

@ihmels ihmels commented Oct 9, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #33926
License MIT
Doc PR -

javiereguiluz
javiereguiluz approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice first contribution to Symfony. Thanks Yannick!

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Oct 9, 2019
@nicolas-grekas
Copy link
Member

Thank you @ihmels.

nicolas-grekas added a commit that referenced this pull request Oct 9, 2019
@nicolas-grekas
bug #33927 Allow to set SameSite config to 'none' (ihmels)
ac422db 
This PR was merged into the 4.3 branch.

Discussion
----------

Allow to set SameSite config to 'none'

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #33926
| License       | MIT
| Doc PR        | -

Commits
-------

eec7e8c Allow to set cookie_samesite to 'none'
@nicolas-grekas nicolas-grekas merged commit eec7e8c into symfony:4.3 Oct 9, 2019
@fabpot fabpot mentioned this pull request Nov 1, 2019
Merged
@NielsCorneille
Copy link

It is still missing on the documentation https://symfony.com/doc/current/reference/configuration/framework.html#cookie-samesite

@chalasr
Copy link
Member

chalasr commented Mar 17, 2020

@NielsCorneille Please consider opening an issue/PR on https://github.com/symfony/symfony-docs

@ihmels ihmels deleted the cookie-samesite-config branch June 22, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@stof stof stof approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ihmels @nicolas-grekas @NielsCorneille @chalasr @javiereguiluz @stof @carsonbot