Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Throw a TypeError for non-int return value calling Command::execute() #33808

Merged
merged 3 commits into from
Oct 2, 2019
Merged

[Console] Throw a TypeError for non-int return value calling Command::execute() #33808

merged 3 commits into from
Oct 2, 2019

Conversation

jschaedl
Copy link
Contributor

@jschaedl jschaedl commented Oct 2, 2019 •
edited

Q A
Branch? 5.0
Bug fix? no
New feature? no
Deprecations? yes
Tickets Fix #33747
License MIT
Doc PR -

Todo

@jschaedl jschaedl mentioned this pull request Oct 2, 2019
Closed
@jschaedl jschaedl marked this pull request as ready for review October 2, 2019 15:01
@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Oct 2, 2019
@jschaedl jschaedl force-pushed the issue-33747-2 branch 2 times, most recently from 81b5ba6 to a7f0ae1 Compare October 2, 2019 17:13
@jschaedl jschaedl changed the title [Console] Throw an Exception for non-int return value calling Command::execute() [Console] Throw a TypeError for non-int return value calling Command::execute() Oct 2, 2019
nicolas-grekas added a commit that referenced this pull request Oct 2, 2019
@nicolas-grekas
minor #33808 [Console] Throw a TypeError for non-int return value cal…
ebda9d1 
…ling Command::execute() (jschaedl)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Console] Throw a TypeError for non-int return value calling Command::execute()

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #33747 <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | - <!-- required for new features -->

### Todo

- [x] needs to be rebased after 4.4 was merged into master (see: #33805)

Commits
-------

b3a3b0c [Console] Throw a TypeError for non-int return values on calling Command::execute()
@nicolas-grekas nicolas-grekas merged commit b3a3b0c into symfony:master Oct 2, 2019
@nicolas-grekas
Copy link
Member

Thank you @jschaedl

@howyi howyi mentioned this pull request Jan 16, 2020
Closed
@jschaedl jschaedl deleted the issue-33747-2 branch February 23, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees
No one assigned
Labels
BC Break Console Status: Needs Review
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jschaedl @nicolas-grekas @carsonbot