[ErrorHandler] don't throw deprecations for return-types by default #33708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
eh-retype
branch
2 times, most recently
from
5af1ffa
to
354d3dc
Compare
nicolas-grekas
force-pushed
the
eh-retype
branch
from
354d3dc
to
2cb419e
Compare
fabpot
approved these changes
Sep 25, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 25, 2019
… by default (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [ErrorHandler] don't throw deprecations for return-types by default | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #33235 | License | MIT | Doc PR | - As discussed a few times already, in 4.4, `DebugClassLoader` shouldn't trigger deprecations when return types are missing. We'll enable them back in 5.1. Commits ------- 2cb419e [ErrorHandler] don't throw deprecations for return-types by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed a few times already, in 4.4,
DebugClassLoadershouldn't trigger deprecations when return types are missing. We'll enable them back in 5.1.