[HttpFoundation] Add types to private/final/internal methods and constructors #33410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
derrabus
commented
Sep 1, 2019
derrabus
commented
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #32179, #33228 |
| License | MIT |
| Doc PR | N/A |
|
If you plan to do one PR per component, I'd prefer one PR to update them all instead if possible :) |
|
Smaller PRs are mainly easier for me to handle at the moment. But if that’s jamming up the PR tracker, I’ll make larger ones. I doubt that one single gigantic PR for everything would be a good idea though. |
derrabus
force-pushed
the
improvement/http-foundation-types
branch
from
10ae5f4
to
1978d88
Compare
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 8, 2019
…hods and constructors (derrabus) This PR was merged into the 4.4 branch. Discussion ---------- [HttpFoundation] Add types to private/final/internal methods and constructors | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179, #33228 | License | MIT | Doc PR | N/A Commits ------- 1978d88 [HttpFoundation] Add types to private/final/internal methods and constructors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.