Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PHP 7.4 on deps=low #33288

Merged
merged 1 commit into from Aug 22, 2019
Merged

Use PHP 7.4 on deps=low #33288

merged 1 commit into from Aug 22, 2019

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Having a job on PHP 7.4 will allow using return type covariance as described in #33236

@nicolas-grekas
Copy link
Member Author

Now green after splitting the failures related to #32995 in a separate job.
(note that I'm quite worried by #32995, and I think we all should: thousands of app will just break)

nicolas-grekas added a commit that referenced this pull request Aug 22, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

Use PHP 7.4 on deps=low

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Having a job on PHP 7.4 will allow using return type covariance as described in #33236

Commits
-------

21b8702 Use PHP 7.4 on deps=low
@nicolas-grekas nicolas-grekas merged commit 21b8702 into symfony:3.4 Aug 22, 2019
@nicolas-grekas nicolas-grekas deleted the php74 branch August 23, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants