Add parameter type declarations to magic methods #33267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
derrabus
commented
Aug 20, 2019
derrabus
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #32179 |
| License | MIT |
| Doc PR | N/A |
Tobion
approved these changes
Aug 21, 2019
derrabus
force-pushed
the
improvement/magic-method-types
branch
from
7486185
to
9b8f420
Compare
derrabus
force-pushed
the
improvement/magic-method-types
branch
from
9b8f420
to
4c5d84d
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Aug 23, 2019
…-grekas) This PR was merged into the 4.4 branch. Discussion ---------- Add missing return annotations on magic methods | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - My script had a bug, spotted by reviewing #33267 These annotations express our intention to add real return types in a future major release (likely v6) Commits ------- 10983fc Add missing return annotations on magic methods
derrabus
force-pushed
the
improvement/magic-method-types
branch
from
4c5d84d
to
ec8215c
Compare
|
I have resolved the conflict. PR is ready again. |
nicolas-grekas
approved these changes
Aug 30, 2019
fabpot
approved these changes
Aug 30, 2019
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Aug 30, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- Add parameter type declarations to magic methods | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | N/A Commits ------- ec8215c Add parameter type declarations to magic methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.