Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ProxyManager] fix closure binding #33180

Merged
merged 1 commit into from Aug 15, 2019
Merged

[ProxyManager] fix closure binding #33180

merged 1 commit into from Aug 15, 2019

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #33037
License MIT
Doc PR -

Follows #32992

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Aug 15, 2019
@nicolas-grekas nicolas-grekas changed the base branch from 4.4 to 3.4 August 15, 2019 08:24
@nicolas-grekas nicolas-grekas mentioned this pull request Aug 15, 2019
Closed
@nicolas-grekas nicolas-grekas merged commit 31f9208 into symfony:3.4 Aug 15, 2019
nicolas-grekas added a commit that referenced this pull request Aug 15, 2019
@nicolas-grekas
minor #33180 [ProxyManager] fix closure binding (nicolas-grekas)
1e47f0f 
This PR was merged into the 3.4 branch.

Discussion
----------

[ProxyManager] fix closure binding

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #33037
| License       | MIT
| Doc PR        | -

Follows #32992

Commits
-------

31f9208 [ProxyManager] fix closure binding
@nicolas-grekas nicolas-grekas deleted the proxy-fix branch August 23, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Devristo Devristo Devristo left review comments

Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicolas-grekas @Devristo @carsonbot