[Intl] Full alpha3 language support #33140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TerjeBr
reviewed
Aug 13, 2019
|
Ready. This PR updates the list of alpha3 language codes from 180 to 589. The old list only referenced the alpha3 codes with a alpha2 mapping. |
TerjeBr
suggested changes
Aug 13, 2019
Merged
TerjeBr
suggested changes
Aug 14, 2019
TerjeBr
reviewed
Aug 14, 2019
TerjeBr
reviewed
Aug 14, 2019
TerjeBr
reviewed
Aug 14, 2019
TerjeBr
reviewed
Aug 14, 2019
TerjeBr
reviewed
Aug 14, 2019
TerjeBr
reviewed
Aug 14, 2019
TerjeBr
reviewed
Aug 14, 2019
TerjeBr
reviewed
Aug 14, 2019
|
@TerjeBr i resolved all your reviews, i think we have to settle here for now :) Thanks for reviewing, much appreciated. If i forgot or overlooked any of your concerns still, let me know. |
TerjeBr
approved these changes
Aug 14, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Aug 14, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Intl] Explicit check | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> This avoids a little conflict with #33140 data is not impacted (today), but i like to make our data selection as explicit as possible and avoid ever pulling in `deprecated` or e.g. `legacy` languages. Commits ------- fbd4ce4 [Intl] Explicit check
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Aug 18, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Intl] Full alpha3 language support | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #33136 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> I'll validate some more cases with tests. Commits ------- 29aee2d [Intl] Full alpha3 language support
fabpot
added a commit
that referenced
this pull request
Sep 27, 2019
…lized language names) (ro0NL) This PR was merged into the 4.4 branch. Discussion ---------- [Intl] Excludes locale from language codes (split localized language names) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #33146 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> (includes #33140) Commits ------- 1a9f517 [Intl] Excludes locale from language codes (split localized language names)
|
Thank you very much for this update. So, will you be working on #33165 next? |
|
Hi @terjebraten-certua that's the last one yes, but i dont have any time real soon to work on the topic. Happy to review though :) Also perhaps see what ICU65 #33548 brings us first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll validate some more cases with tests.