[VarDumper] Fix test patern to handle callstack with/without return typehint #33067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
force-pushed
the
fix-test-testFromCallableClosureCaster
branch
from
c480bd9
to
feaadd1
Compare
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 8, 2019
…hout return typehint (jderusse) This PR was merged into the 4.3 branch. Discussion ---------- [VarDumper] Fix test patern to handle callstack with/without return typehint | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32844 | License | MIT | Doc PR | NA The TestCase::tearDownAfterClass methods does not always have the same signature which change the output of the reflection. This use another methods for testing Commits ------- feaadd1 Fix tst patern to handle callstack with/without return typehint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TestCase::tearDownAfterClass methods does not always have the same signature which change the output of the reflection. This use another methods for testing