[Intl] Order alpha2 to alpha3 mapping + phpdoc fixes #32919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Aug 4, 2019
There was a problem hiding this comment.
(but should be rebased on top of #32918 once merge, also please confirm that none of the docblock changes apply to 3.4)
|
confirmed none of the docblocks apply to 3.4 :) the new static api is introduced in 4.3, i'll let the legacy api in 3.4 rest in peace. |
fabpot
approved these changes
Aug 5, 2019
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Aug 5, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Intl] Order alpha2 to alpha3 mapping + phpdoc fixes | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32676 (review) | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> includes #32918 Commits ------- 867e3de [Intl] Order alpha2 to alpha3 mapping + phpdoc fixes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes #32918