New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#32853 Check if $this->parameters is array. #32870
Conversation
ABGEO
commented
Aug 1, 2019
•
edited
edited
Q | A |
---|---|
Branch? | 4.3 |
Bug fix? | yes |
New feature? | no |
Tests pass? | yes |
Fixed tickets | #32853 |
License | MIT |
Would it work if we initializer the property to the empty array when it is declared instead? |
@nicolas-grekas Yes, it will. If the array is empty, it will return false. |
Great, can you update the patch then please? |
What do you mean by updating the patch? :) |
I mean: change the patch to initialize the property, and revert the current changes. |
@nicolas-grekas Done and it works. |
Thank you @ABGEO07. |
This PR was submitted for the 4.3 branch but it was squashed and merged into the 3.4 branch instead (closes #32870). Discussion ---------- | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Tests pass? | yes | Fixed tickets | #32853 | License | MIT Commits ------- 7cf9ed6 #32853 Check if $this->parameters is array.