Ensure signatures for setUp|tearDown|setUpAfterClass|tearDownAfterClass methods in tests are compatible with phpunit 8.2 #32854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks :) |
|
Done. |
luispabon
changed the title
nicolas-grekas
approved these changes
Aug 1, 2019
…ss methods in tests are compatible with phpunit 8.2
nicolas-grekas
force-pushed
the
4.3/phpunit82-void-setup-teardown
branch
from
48deeaf
to
97bcb5d
Compare
|
Thank you @luispabon. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 1, 2019
…rDownAfterClass methods in tests are compatible with phpunit 8.2 (luispabon) This PR was squashed before being merged into the 4.3 branch (closes #32854). Discussion ---------- Ensure signatures for setUp|tearDown|setUpAfterClass|tearDownAfterClass methods in tests are compatible with phpunit 8.2 | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | #32844 | License | MIT | Doc PR | n/a Please bear with me as this is my first pr to symfony. Branched off 4.3 as requested here: #32844 Tests currently do not pass due to: ``` PHP Fatal error: Declaration of Symfony\Bridge\Monolog\Logger::reset() must be compatible with Monolog\Logger::reset(): void in /home/luis/Projects/symfony/src/Symfony/Bridge/Monolog/Logger.php on line 23 ``` Commits ------- 97bcb5d Ensure signatures for setUp|tearDown|setUpAfterClass|tearDownAfterClass methods in tests are compatible with phpunit 8.2
|
👍 |
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please bear with me as this is my first pr to symfony. Branched off 4.3 as requested here: #32844
Tests currently do not pass due to: