[PhpUnitBridge] Add assertIsX methods in ForwardCompatTestTrait #32848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fabbot want to remove |
OskarStark
reviewed
Aug 1, 2019
| * | ||
| * @return void | ||
| */ | ||
| public static function assertIsArray($actual, $message = '') |
There was a problem hiding this comment.
Suggested change
| public static function assertIsArray($actual, $message = '') | |
| public static function assertIsArray($actual, string $message = '') |
should be no problem, right?
There was a problem hiding this comment.
not compatible with php 5. The bridge don't use the same version of PHP.
symfony/src/Symfony/Bridge/PhpUnit/composer.json
Lines 18 to 22 in f830226
|
closing this PR as #32846 (already merged) contains the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhpUnit 8 deprecates the method
assertInternalTypein favor ofassertIsX. This PR add the polyfill methodsassertIsXin theForwardCompatTestTraitForV5. It'sq a requirement to update tests in order to be compatible with both PhpUnit 5 and 8note: this PR split the PR #32846 to provides methods in the branch
masterin order to fix the test suite for #32846