[DependencyInjection] Added type-hints on compiler passes #32238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 tasks
derrabus
force-pushed
the
improvement/type-hints-on-di-passes
branch
from
fc79d66
to
0a24e51
Compare
src/Symfony/Component/DependencyInjection/Compiler/AbstractRecursivePass.php
Outdated
Show resolved
Hide resolved
derrabus
force-pushed
the
improvement/type-hints-on-di-passes
branch
from
0a24e51
to
d5bc28a
Compare
fabpot
approved these changes
Jun 29, 2019
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Jun 29, 2019
…s (derrabus) This PR was merged into the 5.0-dev branch. Discussion ---------- [DependencyInjection] Added type-hints on compiler passes | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | N/A First part of type-hints for the DependencyInjection component. I've started with the compiler passes and since there's quite a lot of them, I've decided to split them off. Commits ------- d5bc28a [DependencyInjection] Added type-hints on compiler passes.
fabpot
added a commit
that referenced
this pull request
Jul 3, 2019
This PR was merged into the 4.2 branch. Discussion ---------- [DependencyInjection] Removed unused field | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A A minor issue I discovered while analyzing the DI component for #32238: `AnalyzeServiceReferencesPass` defines a private field `$expressionLanguage` that is not used. Commits ------- 5865140 Removed unused field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of type-hints for the DependencyInjection component. I've started with the compiler passes and since there's quite a lot of them, I've decided to split them off.