Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OptionResolver] Add type-hints to OptionResolver class #32235

Merged

Conversation

jschaedl
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32179
License MIT
Doc PR N/A

This PR adds type hints to the OptionResolver class.

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Jun 28, 2019
@fabpot
Copy link
Member

fabpot commented Jun 29, 2019

Thank you @jschaedl.

@fabpot fabpot merged commit b26b37d into symfony:master Jun 29, 2019
fabpot added a commit that referenced this pull request Jun 29, 2019
…(jschaedl)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[OptionResolver] Add type-hints to OptionResolver class

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #32179  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A <!-- required for new features -->

This PR adds type hints to the `OptionResolver` class.

Commits
-------

b26b37d [OptionResolver] Add type-hints to OptionResolver class
@jschaedl jschaedl deleted the improvement/option-resolver_type-hints branch February 23, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants