[PropertyAccess] Add type-hints to public interfaces and classes #32234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschaedl
force-pushed
the
improvement/property-access_type-hints
branch
2 times, most recently
from
d9564fa
to
3c3fb27
Compare
derrabus
reviewed
Jun 28, 2019
| @@ -1700,7 +1700,7 @@ private function registerCacheConfiguration(array $config, ContainerBuilder $con | |||
|
|
|||
| if (!$container->getParameter('kernel.debug')) { | |||
| $propertyAccessDefinition->setFactory([PropertyAccessor::class, 'createCache']); | |||
| $propertyAccessDefinition->setArguments([null, null, $version, new Reference('logger', ContainerInterface::IGNORE_ON_INVALID_REFERENCE)]); | |||
| $propertyAccessDefinition->setArguments([null, 0, $version, new Reference('logger', ContainerInterface::IGNORE_ON_INVALID_REFERENCE)]); | |||
There was a problem hiding this comment.
If that change is necessary, your int type-hint was a small breaking change. We could make the type-hint nullable, but I also prefer int over ?int in that case.
I'd suggest that we backport this change to FrameworkBundle 4.4 along with a deprecation in PropertyAccessor::createCache() that is triggered if null is passed as $defaultLifetime.
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jun 28, 2019
…efaultLifetime argument in createCache method (jschaedl) This PR was squashed before being merged into the 4.4 branch (closes #32241). Discussion ---------- [PropertyAccess] Deprecate null as allowed value for defaultLifetime argument in createCache method | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A<!-- required for new features --> This PR is related to symfony/symfony#32234 (comment) Commits ------- 9aac42698a [PropertyAccess] Deprecate null as allowed value for defaultLifetime argument in createCache method
fabpot
added a commit
that referenced
this pull request
Jun 28, 2019
…efaultLifetime argument in createCache method (jschaedl) This PR was squashed before being merged into the 4.4 branch (closes #32241). Discussion ---------- [PropertyAccess] Deprecate null as allowed value for defaultLifetime argument in createCache method | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A<!-- required for new features --> This PR is related to #32234 (comment) Commits ------- 9aac426 [PropertyAccess] Deprecate null as allowed value for defaultLifetime argument in createCache method
jschaedl
force-pushed
the
improvement/property-access_type-hints
branch
from
3c3fb27
to
2c293f0
Compare
57 tasks
xabbuh
reviewed
Jul 2, 2019
| PropertyAccess | ||
| -------------- | ||
|
|
||
| * Removed support of passing `null` as 2nd argument of `PropertyAccessor::createCache()` method (`$defaultLifetime`), pass `0` instead. |
There was a problem hiding this comment.
This should also be done in #32269 (we always document the deprecation and its removal in the same branch).
fabpot
approved these changes
Jul 5, 2019
fabpot
force-pushed
the
improvement/property-access_type-hints
branch
from
f5e63a2
to
91138a9
Compare
|
Thank you @jschaedl. |
fabpot
added a commit
that referenced
this pull request
Jul 5, 2019
… classes (jschaedl) This PR was squashed before being merged into the 5.0-dev branch (closes #32234). Discussion ---------- [PropertyAccess] Add type-hints to public interfaces and classes | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A <!-- required for new features --> This PR adds type hints to public interfaces and classes of the PropertyAccess component. Some docblocks without valuable information got also removed. Commits ------- 91138a9 [PropertyAccess] Add type-hints to public interfaces and classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds type hints to public interfaces and classes of the PropertyAccess component. Some docblocks without valuable information got also removed.