[Workflow] Added parameter typhint where possible #32223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Jun 27, 2019
lyrixx
commented
| Q | A |
|---|---|
| Branch? | mas |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | ye |
| Fixed tickets | partially #32179 |
| License | MIT |
| Doc PR |
57 tasks
lyrixx
force-pushed
the
workflow-typehint
branch
from
902d6cb
to
37fd645
Compare
lyrixx
force-pushed
the
workflow-typehint
branch
from
37fd645
to
30cccba
Compare
derrabus
requested changes
Jun 28, 2019
|
Are you OK with this one? cc @derrabus |
derrabus
approved these changes
Jul 4, 2019
| * @param Definition $definition A Definition instance | ||
| * @param Marking|null $marking A Marking instance | ||
| * @param array $options An array of options | ||
| * |
There was a problem hiding this comment.
This should be done on a lower branch.
There was a problem hiding this comment.
Let's minimize the changes that don't add value to the code. Keeping that in lower branches is fine by me.
| @@ -27,9 +28,9 @@ class GuardEvent extends Event | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function __construct($subject, Marking $marking, Transition $transition, $workflowName = null) | |||
There was a problem hiding this comment.
The $workflowName => WorkflowInterface $workflow = null change should be done on a lower branch.
fabpot
approved these changes
Jul 5, 2019
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
Jul 5, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Workflow] Added parameter typhint where possible | Q | A | ------------- | --- | Branch? | mas | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | ye | Fixed tickets | partially #32179 | License | MIT | Doc PR | Commits ------- 62e615b [Workflow] Added parameter typhint where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.