[Config] Add type-hints to public interfaces and classes #32201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschaedl
force-pushed
the
improvement/config-type-hints
branch
2 times, most recently
from
00875f5
to
0254139
Compare
57 tasks
|
Please also update those implementations of the updated interfaces that are also part of the Config component. |
| @@ -26,7 +26,7 @@ interface LoaderInterface | |||
| * | |||
| * @throws \Exception If something went wrong | |||
| */ | |||
| public function load($resource, $type = null); | |||
| public function load($resource, ?string $type = null); | |||
There was a problem hiding this comment.
? should be removed (same below when null is the default), per our CS
jschaedl
commented
Jun 28, 2019
| @@ -115,6 +115,6 @@ public function testLocateEmpty() | |||
| { | |||
| $loader = new FileLocator([__DIR__.'/Fixtures']); | |||
|
|
|||
| $loader->locate(null, __DIR__); | |||
| $loader->locate('', __DIR__); | |||
There was a problem hiding this comment.
This test expected an InvalidArgumentException but gets a TypeError now.
jschaedl
force-pushed
the
improvement/config-type-hints
branch
from
ee3536a
to
ae54f82
Compare
jschaedl
changed the title
fabpot
approved these changes
Jun 29, 2019
fabpot
force-pushed
the
improvement/config-type-hints
branch
from
ae54f82
to
e069dc4
Compare
|
Thank you @jschaedl. |
fabpot
added a commit
that referenced
this pull request
Jun 29, 2019
… (jschaedl) This PR was squashed before being merged into the 5.0-dev branch (closes #32201). Discussion ---------- [Config] Add type-hints to public interfaces and classes | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A <!-- required for new features --> This PR adds type hints to all public interfaces of the Config component. Commits ------- e069dc4 [Config] Add type-hints to public interfaces and classes
Tobion
reviewed
Jun 29, 2019
| */ | ||
| public function setPerformDeepMerging($boolean) | ||
| public function setPerformDeepMerging(bool $boolean) | ||
| { | ||
| $this->performDeepMerging = (bool) $boolean; |
Tobion
reviewed
Jun 29, 2019
| @@ -23,5 +23,5 @@ interface PrototypeNodeInterface extends NodeInterface | |||
| * | |||
| * @param string $name The name of the node | |||
Tobion
reviewed
Jun 29, 2019
| @@ -33,7 +33,7 @@ public function __construct($paths = []) | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function locate($name, $currentPath = null, $first = true) | |||
| public function locate(string $name, string $currentPath = null, $first = true) | |||
Tobion
reviewed
Jun 29, 2019
| @@ -28,5 +28,5 @@ interface ConfigCacheFactoryInterface | |||
| * | |||
| * @return ConfigCacheInterface The cache instance | |||
| */ | |||
| public function cache($file, $callable); | |||
| public function cache(string $file, $callable); | |||
|
@Tobion Thanks. I will create a follow-up PR to address your comments. |
jschaedl
added a commit
to jschaedl/symfony
that referenced
this pull request
Jun 29, 2019
jschaedl
added a commit
to jschaedl/symfony
that referenced
this pull request
Jun 29, 2019
fabpot
added a commit
that referenced
this pull request
Jul 5, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Config] finish adding parameter types | Q | A | ------------- | --- | Branch? | master | Bug fix? | yno | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Completes some missing things in #32201 Commits ------- 2ca8354 [Config] finish adding parameter types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds type hints to all public interfaces of the Config component.