Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHPUnit] Fixed composer error on Windows #32187

Merged
merged 1 commit into from Jul 3, 2019
Merged

Conversation

misterx
Copy link
Contributor

@misterx misterx commented Jun 26, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #31750
License MIT

Fixes bug when composer runs from bat file that described in PATH env.

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for 3.4)

@fabpot fabpot changed the base branch from 4.3 to 3.4 July 3, 2019 17:13
@fabpot
Copy link
Member

fabpot commented Jul 3, 2019

Thank you @misterx.

@fabpot fabpot merged commit 1f8927a into symfony:3.4 Jul 3, 2019
@nicolas-grekas
Copy link
Member

I'm going to revert: this break our CI, see eg https://ci.appveyor.com/project/fabpot/symfony/builds/25755239
Other fix welcome...

@nicolas-grekas
Copy link
Member

I finally figured out the proper fix: d9833ac

This was referenced Jul 27, 2019
@misterx misterx deleted the patch-2 branch October 7, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants