[Routing] Fixed type annotation #32185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Jun 26, 2019
fabpot
approved these changes
Jun 26, 2019
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Jun 26, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Routing] Fixed type annotation | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A The `UrlGeneratorInterface::generate()` method expects an array as argument `$parameters`, but the docblock does not reflect that. This PR fixes the type. Discovered while working on #32176. Commits ------- 753bf7e Fixed type annotation.
|
This does not seem correct. Our implementation expects an array. But others might not. The idea was to allow to generate urls from objects, see 04ac1fd |
|
But then, our own implementation should deal properly with non-array values ( |
|
Yeah we should probably throw an explicit exception. |
|
I know there was a bundle allowing to generate urls from objects. But I've never used it and don't know if its maintained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UrlGeneratorInterface::generate()method expects an array as argument$parameters, but the docblock does not reflect that. This PR fixes the type. Discovered while working on #32176.