[DI] Failing test case for complex near-circular situation + lazy #32157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
Jun 24, 2019
|
|
||
| // doctrine-like event system with small differences | ||
|
|
||
| $container->register('manager4', 'stdClass') |
There was a problem hiding this comment.
This is a second case that's actually unrelated, but I stumbled upon it. For some reason, if connection4 is NOT public, you get a nesting exception.
There was a problem hiding this comment.
Could be worth to add this explanation as a comment code ?
Lctrs
reviewed
Jun 24, 2019
src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/Dumper/PhpDumperTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
doctrine-almost-circular-failing-test
branch
3 times, most recently
from
dd60aa9
to
c694216
Compare
nicolas-grekas
force-pushed
the
doctrine-almost-circular-failing-test
branch
from
c694216
to
4c03af4
Compare
|
Thank you @weaverryan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the failing test case. But hopefully, this can get things moving :)