[Messenger] fix delay delivery for non-fanout exchanges #32035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
commented
Jun 14, 2019
| * * prefetch_count: set channel prefetch count | ||
| */ | ||
| public function __construct(array $connectionOptions, array $exchangeOptions, array $queuesOptions, AmqpFactory $amqpFactory = null) |
There was a problem hiding this comment.
I moved the options phpdoc from constructor to fromDsn because the constructor does have different parameters for different options (exchange, queue). So the options doc there makes no sense.
Tobion
commented
Jun 14, 2019
| @@ -81,29 +93,19 @@ class Connection | |||
| * * delay: | |||
| * * routing_key_pattern: The pattern of the routing key (Default: "delay_%routing_key%_%delay%") | |||
| * * queue_name_pattern: Pattern to use to create the queues (Default: "delay_queue_%routing_key%_%delay%") | |||
| * * exchange_name: Name of the exchange to be used for the retried messages (Default: "retry") | |||
Tobion
commented
Jun 14, 2019
| * * auto_setup: Enable or not the auto-setup of queues and exchanges (Default: true) | ||
| * * loop_sleep: Amount of micro-seconds to wait if no message are available (Default: 200000) |
There was a problem hiding this comment.
this is in the worker now
also fix dsn parsing of plain amqp:// uri
Tobion
force-pushed
the
fix-messenger-retry-with-non-fanout-exchange
branch
from
e9a587f
to
0f15306
Compare
fabpot
approved these changes
Jun 14, 2019
Tobion
added a commit
that referenced
this pull request
Jun 14, 2019
…obion) This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] fix delay delivery for non-fanout exchanges | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Fixes two bugs and outdated phpdoc: 1. When your exchange is not of type fanout, but direct for example, then delivery of delayed (retrying) messages does not work. This is because the delay logics adds a routing key to message. It was fixed if you have a custom routing key in #31355. But if you have no routing key, it still changed the routing key which means the message will not be delivery from your direct exchange to your queue anymore after being in the delay exchange. For fanout, which is the default, it does not matter because the routing key is ignored. 2. also fix dsn parsing of plain `amqp://` which is a valid URI that parse_url cannot handle when you want to pass all parameters as options Commits ------- 0f15306 [Messenger] fix delay delivery for non-fanout exchanges
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs and outdated phpdoc:
amqp://which is a valid URI that parse_url cannot handle when you want to pass all parameters as options