Remove deprecated code paths that trigger a runtime notice #31957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jun 8, 2019
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
nicolas-grekas
commented
Jun 8, 2019
nicolas-grekas
force-pushed
the
5-gen-cleanu
branch
3 times, most recently
from
8e0b4f3
to
5a1dc1e
Compare
nicolas-grekas
commented
Jun 9, 2019
| @@ -48,7 +48,7 @@ public function onAuthentication(Request $request, TokenInterface $token) | |||
|
|
|||
| case self::MIGRATE: | |||
| // Note: this logic is duplicated in several authentication listeners | |||
| // until Symfony 5.0 due to a security fix with BC compat | |||
| // until Symfony 5.0 due to a security fix with BC compat XXX | |||
There was a problem hiding this comment.
What does this mean for 5.0 @weaverryan? What should be done now?
There was a problem hiding this comment.
removing the duplicated logic in other listener I think
There was a problem hiding this comment.
this is the only remaining part that I didn't update in this PR
@weaverryan maybe, up for a PR?
nicolas-grekas
force-pushed
the
5-gen-cleanu
branch
from
5a1dc1e
to
133325a
Compare
|
👍 for the workflow part |
nicolas-grekas
force-pushed
the
5-gen-cleanu
branch
from
133325a
to
818444c
Compare
nicolas-grekas
force-pushed
the
5-gen-cleanu
branch
from
818444c
to
3962248
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jun 9, 2019
…ce (nicolas-grekas) This PR was merged into the 5.0-dev branch. Discussion ---------- Remove deprecated code paths that trigger a runtime notice | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 3962248 Remove deprecated code paths that trigger a runtime notice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.