New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Symfony 5.0 to PHP 7.2 #31655
Bump Symfony 5.0 to PHP 7.2 #31655
Conversation
Why not |
The question is more: why 7.3? |
edit: d'oh that's 7.4 |
@ciaranmcnulty don't you talk about 7.4? See https://www.php.net/releases/7_3_0.php |
I'd be in favor of PHP 7.3 too as 7.2 active support ends on November, 30 2019, so at the same time Symfony 5.0 will be released. |
Since 7.4 will happen at the same time as sf5, it is probably too early to make that a minimal? |
7.2 is all we need to start working on Symfony 5.0. |
@nicolas-grekas you are of course right. I forgot 7.3 had so few compelling features (some nice stuff but nothing that would require it over 7.2) |
Okay, I agree that as a minimum version |
I'm for 7.2 too. 7.3 does not bring so much nice features. 7.2 seems better for adoption. |
👍 7.2 for now. Ref. #24283 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7.2 is a good choice for now: it allows strict typing, allows for parameter type widening in implementations (which is necessary during a migration to strict typing) and it has been widely adopted.
7.3 on the other hand lacks clear features that make it stand out, and 7.4 will not be released in time to be considered at all.
This PR was merged into the 5.0-dev branch. Discussion ---------- Bump Symfony 5.0 to PHP 7.2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Not ready yet. 7.2 because it has all we need for the next two years (7.3 doesn't provide anything we absolutely need, and 7.4 is not even released so cannot be considered yet.) 7.2.9 because of https://tracker.debian.org/pkg/php7.2 Needs: - [x] symfony/security-acl#48 - [x] doctrine/orm#7723 - [x] doctrine/DoctrineBundle#975 - [x] doctrine/DoctrineCacheBundle#158 - [x] symfony#31657 Commits ------- d94d9d7 Bump Symfony 5.0 to PHP 7.2
Not ready yet.
7.2 because it has all we need for the next two years (7.3 doesn't provide anything we absolutely need, and 7.4 is not even released so cannot be considered yet.)
7.2.9 because of https://tracker.debian.org/pkg/php7.2
Needs: