Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Symfony 5.0 to PHP 7.2 #31655

Merged
merged 1 commit into from May 28, 2019
Merged

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented May 28, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Not ready yet.

7.2 because it has all we need for the next two years (7.3 doesn't provide anything we absolutely need, and 7.4 is not even released so cannot be considered yet.)

7.2.9 because of https://tracker.debian.org/pkg/php7.2

Needs:

@vudaltsov
Copy link
Contributor

Why not 7.3?

@nicolas-grekas
Copy link
Member Author

The question is more: why 7.3?
7.2 is better for adoption.

@ciaranmcnulty
Copy link
Contributor

ciaranmcnulty commented May 28, 2019

Typed private properties would be a good driver for 7.3 I think?

edit: d'oh that's 7.4

@nicolas-grekas
Copy link
Member Author

@ciaranmcnulty don't you talk about 7.4? See https://www.php.net/releases/7_3_0.php

@jmsche
Copy link
Contributor

jmsche commented May 28, 2019

I'd be in favor of PHP 7.3 too as 7.2 active support ends on November, 30 2019, so at the same time Symfony 5.0 will be released.

@kunicmarko20
Copy link

kunicmarko20 commented May 28, 2019

Since 7.4 will happen at the same time as sf5, it is probably too early to make that a minimal?

@nicolas-grekas
Copy link
Member Author

7.2 is all we need to start working on Symfony 5.0.

@ciaranmcnulty
Copy link
Contributor

@nicolas-grekas you are of course right. I forgot 7.3 had so few compelling features (some nice stuff but nothing that would require it over 7.2)

@vudaltsov
Copy link
Contributor

Okay, I agree that as a minimum version 7.2 is good.

@lyrixx
Copy link
Member

lyrixx commented May 28, 2019

I'm for 7.2 too. 7.3 does not bring so much nice features. 7.2 seems better for adoption.

@Tobion
Copy link
Member

Tobion commented May 28, 2019

👍 7.2 for now. Ref. #24283
Maybe bump to 7.4 later if released in time. Then we would use the latest PHP version like done with SF 4.

Copy link
Contributor

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.2 is a good choice for now: it allows strict typing, allows for parameter type widening in implementations (which is necessary during a migration to strict typing) and it has been widely adopted.

7.3 on the other hand lacks clear features that make it stand out, and 7.4 will not be released in time to be considered at all.

nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull request May 28, 2019
This PR was merged into the 5.0-dev branch.

Discussion
----------

Bump Symfony 5.0 to PHP 7.2

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Not ready yet.

7.2 because it has all we need for the next two years (7.3 doesn't provide anything we absolutely need, and 7.4 is not even released so cannot be considered yet.)

7.2.9 because of https://tracker.debian.org/pkg/php7.2

Needs:
- [x] symfony/security-acl#48
- [x] doctrine/orm#7723
- [x] doctrine/DoctrineBundle#975
- [x] doctrine/DoctrineCacheBundle#158
- [x] symfony#31657

Commits
-------

d94d9d7 Bump Symfony 5.0 to PHP 7.2
@nicolas-grekas nicolas-grekas merged commit d94d9d7 into symfony:master May 28, 2019
@nicolas-grekas nicolas-grekas deleted the php72 branch May 28, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants